Add Interval #441
Open
Add Interval #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
requested changes
Jul 24, 2024
src/Interval.php
Outdated
Comment on lines
30
to
33
| public function __destruct() | ||
| { | ||
| EventLoop::cancel($this->watcher); | ||
| } |
There was a problem hiding this comment.
Shouldn't there also be a manual cancel method?
There was a problem hiding this comment.
I think it makes more sense for the object to represent a valid repeating timer. If we allow external cancellation, then the object needs to expose an isCancelled() method so the state isn't hidden.
|
It's just a |
|
How about moving this to |
|
I'd rather keep this here, as it's very basic, no? |
|
@kelunik Yeah, I can't see this needing changing, so seems basic enough to go here. Should we add this then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a utility class
Intervalwhich controls a repeating timer, automatically cancelling the timer when the object is destroyed.The main use-case of this object is to store an instance of
Intervalas an object property. When the holding object is destroyed, the repeating timer will be cancelled. This avoids a bit of boilerplate in the class, such as needing to declare a destructor to manually cancel the event loop callback.The value here isn't necessarily huge, but this is a pattern we frequently use for classes with self-cleanup mechanisms such as
LocalCache.